Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[NT-1317] Send Optimizely Events with the SDK #1223

Merged
merged 2 commits into from
Jun 11, 2020
Merged

[NT-1317] Send Optimizely Events with the SDK #1223

merged 2 commits into from
Jun 11, 2020

Conversation

jgsamudio
Copy link
Contributor

@jgsamudio jgsamudio commented Jun 10, 2020 •
edited by ifbarrera
Loading

📲 What

Send the Optimizely client events through the app

🤔 Why

Sending events to Optimizely's dashboard through the DataLake proved to have issues and the short term solution is to send those events through the client SDK.

🛠 How

✅ Acceptance criteria

  • Tests pass and events are sent to Optimizely correctly

@jgsamudio jgsamudio changed the title Add optimizely tracking calls back to the sdk. [NT-1317] Send active Optimizely events to the Optimizely SDK Jun 10, 2020
@jgsamudio jgsamudio changed the title [NT-1317] Send active Optimizely events to the Optimizely SDK [NT-1317] Send Optimizely Events with the SDK Jun 10, 2020
ifbarrera
ifbarrera reviewed Jun 10, 2020
View reviewed changes
@nativeksr
Copy link
Collaborator

1 Warning
⚠️ Big PR

Generated by 🚫 Danger

@jgsamudio jgsamudio force-pushed the chore/optimizely_event_sdk branch from 2d4649a to 2be47c0 Compare June 11, 2020 14:38
ifbarrera
ifbarrera reviewed Jun 11, 2020
View reviewed changes
Copy link
Contributor

@ifbarrera ifbarrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a few failing tests in Library-iOSTests you might want to take a look at. Probably assertions just need to be tweaked slightly.

@jgsamudio jgsamudio force-pushed the chore/optimizely_event_sdk branch from 2be47c0 to 885e3b0 Compare June 11, 2020 15:13
@jgsamudio
Copy link
Contributor Author

There's a few failing tests in Library-iOSTests you might want to take a look at. Probably assertions just need to be tweaked slightly.

Updated Tests, Passing now

@jgsamudio jgsamudio requested a review from ifbarrera June 11, 2020 15:40
@jgsamudio jgsamudio force-pushed the chore/optimizely_event_sdk branch 2 times, most recently from b44195f to 37d4277 Compare June 11, 2020 16:00
@jgsamudio jgsamudio force-pushed the chore/optimizely_event_sdk branch from 37d4277 to 397edea Compare June 11, 2020 16:49
@jgsamudio jgsamudio requested a review from ifbarrera June 11, 2020 17:25
ifbarrera
ifbarrera approved these changes Jun 11, 2020
View reviewed changes
Copy link
Contributor

@ifbarrera ifbarrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

jgsamudio added 2 commits June 11, 2020 16:49
@jgsamudio
Add optimizely tracking calls back to the sdk.
18e99d2 
Signed-off-by: Jonathan Samudio <jonathan2457@gmail.com>
@jgsamudio
Removed eventTags.
c1fd6c1 
Signed-off-by: Jonathan Samudio <jonathan2457@gmail.com>
@jgsamudio jgsamudio force-pushed the chore/optimizely_event_sdk branch from 397edea to c1fd6c1 Compare June 11, 2020 20:49
@jgsamudio jgsamudio merged commit 7a917a7 into master Jun 11, 2020
@jgsamudio jgsamudio deleted the chore/optimizely_event_sdk branch June 11, 2020 21:29
@justinswart justinswart mentioned this pull request Jun 12, 2020
Merged
1 task
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ifbarrera ifbarrera ifbarrera approved these changes

@justinswart justinswart Awaiting requested review from justinswart

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jgsamudio @nativeksr @ifbarrera