Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix User Settings Regression #1295

Merged
merged 2 commits into from
Sep 18, 2020
Merged

Conversation

justinswart
Copy link
Contributor

📲 What

Fixes a regression in our user account settings which caused changing user settings to error.

🤔 Why

Why indeed. The refactor in #1263 introduced some changes that added a non-nil property uid to GraphUser. The various queries we have that fetch data for our user settings views make use of GraphUser but those queries unfortunately hadn't been updated to include the uid property resulting in GraphUser in those contexts failing to deserialize.

🛠 How

Added GraphUser.baseQueryProperties to UserQueries.

✅ Acceptance criteria

  • All user settings views should be available and functioning.

Copy link
Contributor

@jgsamudio jgsamudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@justinswart justinswart merged commit cdf045b into release-4.8.0 Sep 18, 2020
@justinswart justinswart deleted the fix-settings-regression branch September 18, 2020 15:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants