Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[NT-1567] Fix CircleCI Configuration #1312

Merged
merged 2 commits into from
Oct 1, 2020
Merged

Conversation

justinswart
Copy link
Contributor

@justinswart justinswart commented Sep 30, 2020

📲 What

Fixes some copy-paste typos introduced in #1296.

🤔 Why

We had copy-pasted some lane names when making those changes and our alpha and app store lane names were incorrect.

🛠 How

Fixed the lane names.

@codecov
Copy link

codecov bot commented Sep 30, 2020

Codecov Report

Merging #1312 into master will decrease coverage by 13.48%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1312       +/-   ##
===========================================
- Coverage   85.71%   72.23%   -13.49%     
===========================================
  Files        1109      608      -501     
  Lines       96962    40389    -56573     
===========================================
- Hits        83115    29175    -53940     
+ Misses      13847    11214     -2633     
Impacted Files Coverage Δ
Library/TestHelpers/MockApplication.swift 0.00% <0.00%> (-100.00%) ⬇️
Library/TestHelpers/MockOptimizelyClient.swift 55.55% <0.00%> (-44.45%) ⬇️
Library/TestHelpers/MockBundle.swift 56.25% <0.00%> (-43.75%) ⬇️
Library/TestHelpers/MockApplePayCapable.swift 50.00% <0.00%> (-16.67%) ⬇️
Library/Tracking/MockTrackingClient.swift 78.57% <0.00%> (-7.15%) ⬇️
...rary/ViewModels/SettingsNewslettersViewModel.swift
...wModels/PledgeShippingLocationViewModelTests.swift
Library/FacebookConnectionType.swift
Library/NumberFormatter.swift
...ls/ProjectPamphletCreatorHeaderCellViewModel.swift
... and 496 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12eefbd...5d8d561. Read the comment docs.

Copy link
Contributor

@singhhari singhhari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@justinswart justinswart merged commit c10e44d into master Oct 1, 2020
@justinswart justinswart deleted the NT-1567-fix-ci-bugs branch October 1, 2020 15:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants