Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[NT-1584][NT-1588] Handling rewards and add ons with future start dates #1317

Merged
merged 2 commits into from
Oct 8, 2020

Conversation

singhhari
Copy link
Contributor

📲 What

Currently, backers are able to see rewards and add-ons with future start dates and back them. We want to conditionally render these options for selection only when the appropriate time has been reached.

🤔 Why

Currently, rewards and add-ons with start dates in the future are being shown as available for backing. These should be hidden from view until the start date set by the creator.

🛠 How

We're filtering in the RewardAddOnSelectionViewController and RewardCollectionViewController based on a date check.

@codecov
Copy link

codecov bot commented Oct 7, 2020

Codecov Report

Merging #1317 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1317   +/-   ##
=======================================
  Coverage   85.76%   85.77%           
=======================================
  Files        1109     1109           
  Lines       97283    97339   +56     
=======================================
+ Hits        83437    83493   +56     
  Misses      13846    13846           
Impacted Files Coverage Δ
Library/SharedFunctions.swift 84.23% <100.00%> (+0.53%) ⬆️
Library/SharedFunctionsTests.swift 100.00% <100.00%> (ø)
...ary/ViewModels/RewardAddOnSelectionViewModel.swift 98.46% <100.00%> (-0.02%) ⬇️
...iewModels/RewardAddOnSelectionViewModelTests.swift 99.34% <100.00%> (+0.02%) ⬆️
...ibrary/ViewModels/RewardsCollectionViewModel.swift 99.42% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f21ec4a...6926281. Read the comment docs.

@singhhari singhhari requested a review from andrewKstrt October 8, 2020 15:31
@singhhari singhhari merged commit 1d724fb into master Oct 8, 2020
@singhhari singhhari deleted the NT-1584-reward-not-yet-available branch October 8, 2020 17:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants