Fix missing spinner on BackerDashboardProjectsViewController #2044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amy-at-kickstarter
requested review from
a team and
scottkicks
and removed request for
a team
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Fix a missing loading spinner on
BackerDashboardProjectsViewController.🤔 Why
I noticed this while fixing other bugs - the spinner was frequently missing, and it made the loading feel much slower than it effectively was.
🛠 How
viewWillAppeartoviewDidAppearto fix a warning about using the refresh controller while off screenendRefreshing()call toviewDidDisappear, per a suggestion from StackOverflow. Seems like the refresh controller is strangely sensitive to view lifecycle methods, and this fixes the problem.