[MBL-1386][MBL-1388] Show survey in activity #2058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifosli
requested review from
a team and
scottkicks
and removed request for
a team
Generated by 🚫 Danger |
scottkicks
approved these changes
May 14, 2024
| internal func facebookConnect(source: FriendsSource, visible: Bool) { | ||
| self.set( | ||
| values: visible ? [source] : [], | ||
| cellClass: FindFriendsFacebookConnectCell.self, |
There was a problem hiding this comment.
Can we remove the FindFrendsFacebookConnectCell altogether? Or is it being used somewhere else?
There was a problem hiding this comment.
Removing the cell might mean that the Activity storyboard needs to be updated, which could get wonky....cause storyboards
There was a problem hiding this comment.
No, this one is being used elsewhere. It's likely code that we're not actually using, but I'd need to dig through discover and settings to confirm, so that seems out of scope for this pr.
| internal func findFriends(source: FriendsSource, visible: Bool) { | ||
| self.set( | ||
| values: visible ? [source] : [], | ||
| cellClass: FindFriendsHeaderCell.self, |
There was a problem hiding this comment.
Same question here. Can FindFriendsHeaderCell be removed?
Comment on lines
+351
to
+354
| self.unansweredSurveyResponse.assertValues( | ||
| [[surveyResponse], [surveyResponse]], | ||
| "Survey emits whenever view appears" | ||
| ) |
ifosli
force-pushed
the
showSurveyInActivity
branch
from
a3efb55 to
8123182
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Show unanswered survey cards in activity and delete related code that would show facebook cards.
👀 See
Jira ticket for showing survey
Jira ticket for hiding facebook
Note: Neither of these facebook cards showed before and they're still not going to show. The only change in this pr is that they're actually deleted.
✅ Acceptance criteria