Fix Stripe Link remote configuration flag #2061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -159,10 +159,6 @@ public final class PaymentMethodSettingsViewModel: PaymentMethodsViewModelType, | |||
| configuration.merchantDisplayName = Strings.general_accessibility_kickstarter() | |||
| configuration.allowsDelayedPaymentMethods = true | |||
|
|
|||
| if featureStripeLinkEnabled() { | |||
There was a problem hiding this comment.
Per @tedPen, we don't need to show Stripe Link from the payment method settings screen - only in the pledge flow. Removing this for clarity's sake, since it would never show anyways.
| @@ -354,6 +354,9 @@ public final class PledgePaymentMethodsViewModel: PledgePaymentMethodsViewModelT | |||
|
|
|||
| if featureStripeLinkEnabled() { | |||
| configuration.defaultBillingDetails.email = AppEnvironment.current.currentUserEmail | |||
| configuration.billingDetailsCollectionConfiguration.email = .automatic | |||
| } else { | |||
| configuration.billingDetailsCollectionConfiguration.email = .always | |||
There was a problem hiding this comment.
@ycheng-kickstarter Can you confirm this is what Android is doing? Stripe's documentation is stunningly unclear on this, but it does work for me.
| @@ -354,6 +354,9 @@ public final class PledgePaymentMethodsViewModel: PledgePaymentMethodsViewModelT | |||
|
|
|||
| if featureStripeLinkEnabled() { | |||
| configuration.defaultBillingDetails.email = AppEnvironment.current.currentUserEmail | |||
| configuration.billingDetailsCollectionConfiguration.email = .automatic | |||
There was a problem hiding this comment.
.automatic is the default but setting it explicitly for clarity
scottkicks
approved these changes
May 15, 2024
ycheng-kickstarter
approved these changes
May 15, 2024
| @@ -354,6 +354,9 @@ public final class PledgePaymentMethodsViewModel: PledgePaymentMethodsViewModelT | |||
|
|
|||
| if featureStripeLinkEnabled() { | |||
| configuration.defaultBillingDetails.email = AppEnvironment.current.currentUserEmail | |||
| configuration.billingDetailsCollectionConfiguration.email = .automatic | |||
| } else { | |||
| configuration.billingDetailsCollectionConfiguration.email = .always | |||
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Fix the Stripe Link remote configuration flag, so that it actually controls whether or not Stripe Link is enabled.
May-15-2024.11-22-32.mp4
🤔 Why
Apparently setting the email address was insufficient to control the appearance of Stripe Link. 🤷♀️