[MBL-1631] Remove Shipping Dropdown From Add-Ons #2106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottkicks
force-pushed
the
scott/remove-shipping-dropdown-from-addons
branch
from
56c8eab to
59f7ce2
Compare
scottkicks
commented
Jul 30, 2024
| @@ -254,7 +254,7 @@ private func getRewardIDsToQuery(for project: Project) -> Set<Int> { | |||
| if rewardIDsToQuery.isEmpty { | |||
| let restrictedRewards = project.rewards | |||
| .filter { | |||
| ($0.isRestrictedShippingPreference || $0.isLocalShippingPreference || $0.hasNoShippingPreference) | |||
There was a problem hiding this comment.
local shipping items by default have shipping disabled. removing this check since it isn't a possible case here.
Generated by 🚫 Danger |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Removes the shipping drop-down from our AddOns screen
🤔 Why
The shipping dropdown will only be used on the Rewards screen to filter rewards shown based on location. This is the first step in removing the dropdown from the other places in the app where it's displayed.
🛠 How
This adds a new view controller,
RewardAddOnSelectionNoShippingViewController,which is just a copy ofRewardAddOnSelectionViewControllerwithout the shipping location dropdown.The duplicate class makes it easier for us to gate this behind a feature flag.
👀 See
Feature flag is on
✅ Acceptance criteria