[MBL-1667] Pledge Redemption String Translations #2137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottkicks
force-pushed
the
scott/mbl-1667/update-string-translations
branch
from
32283ea to
5fa6347
Compare
scottkicks
commented
Aug 29, 2024
Comment on lines
+664
to
+668
| public func estimatedShippingText( | ||
| for reward: Reward, | ||
| project: Project, | ||
| selectedShippingRule: ShippingRule | ||
| ) -> String { |
There was a problem hiding this comment.
I needed to update this method to accept the current Project. This allowed me to use the Format.currency() helper which gives us the correct currency symbol and formatting that we need.
scottkicks
commented
Aug 29, 2024
Comment on lines
+321
to
+322
| estimatedShippingText(for: reward, project: project, selectedShippingRule: rule), | ||
| estimatedShippingConversionText(for: reward, project: project, selectedShippingRule: rule) |
There was a problem hiding this comment.
related to my comment above
scottkicks
commented
Aug 29, 2024
Comment on lines
+148
to
+149
| estimatedShippingText(for: reward, project: project, selectedShippingRule: rule), | ||
| estimatedShippingConversionText(for: reward, project: project, selectedShippingRule: rule) |
There was a problem hiding this comment.
also related to my comment above
scottkicks
force-pushed
the
scott/mbl-1667/update-string-translations
branch
from
5fa6347 to
f722dfc
Compare
ifosli
approved these changes
Aug 29, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Pulls in the latest string translations and replaces our hard-coded strings.
🤔 Why
KS supports multiple countries.
🛠 How
run
make stringsupdate hardcoded strings