-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
PPO: View model GraphQL loading and pagination support #2139
Conversation
Generated by 🚫 Danger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good - I left a few minor comments and I'm a little confused by some of the code that got deleted from the PPOView. The "show banner" button was intended to be temporary but the ability to show a banner was not. If you have a different plan for how to show a banner, I'm okay with deleting that code, but then I think we should just delete the geometry reader entirely. Marking this as approved but please fix the banner stuff before submitting!
📲 What
This PR adds support for loading, reloading, and fetching more data for the PPO view. (Integration forthcoming)
🤔 Why
As part of PPO, we need the view to support loading paginated data from GraphQL and converting that into view models for individual cards.
🛠 How
This PR does two things:
✅ Acceptance criteria