[MBL-1687] Fix continue button on confirm details page not working #2147 #2148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -362,10 +362,14 @@ public class ConfirmDetailsViewModel: ConfirmDetailsViewModelType, ConfirmDetail | |||
| return [String](repeating: reward.graphID, count: count) | |||
| } | |||
|
|
|||
| let locationId = selectedShippingRule == nil | |||
There was a problem hiding this comment.
Suggestion: You could do selectedShippingRule.flatMap { String($0.location.id) } to make this one line and remove the ! below (and do the same for NoShippingConfirmDetailsViewModel
stevestreza-ksr
approved these changes
Sep 5, 2024
scottkicks
approved these changes
Sep 5, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
We accidentally introduced a bug where the late pledge flow can't be completed because the location id isn't correctly transformed to a string. This fixes that bug and the "no shipping" test that I thought might be related that ended up not being related after all.
👀 See
Jira
✅ Acceptance criteria