Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add NoShippingPostCampaignCheckoutViewController to payment methods assert #2162

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

ifosli
Copy link
Contributor

@ifosli ifosli commented Sep 25, 2024

📲 What

Our PledgePaymentMethodsViewController has an assert to make sure it's only presented in the pledge flow. The no shipping late pledge flow was missing from the assert, so I'm adding it in.

Note: Since asserts like this default to true in production, there's no impact on our current release.

✅ Acceptance criteria

  • The add payment methods sheet gets presented without crashing the app in debug builds with the "no shipping at pledge" and the "post campaign pledging enabled" flags on.

@ifosli ifosli self-assigned this Sep 25, 2024
@ifosli ifosli marked this pull request as ready for review September 25, 2024 18:12
@ifosli ifosli merged commit 21e31c5 into main Sep 25, 2024
4 checks passed
@ifosli ifosli deleted the paymentMethodsAssertFix branch September 25, 2024 20:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants