[MBL-1738] iPadOS 18 - Navbar overlay issue in "Follow Friends" screen

[jovaniks]

📲 What

• Moved the call to setNavigationBarHidden from viewWillAppear to viewDidAppear in the "Follow Friends" screen.

🤔 Why

The change was needed to fix an issue where the UINavigationBar was overlaying the content of the "Follow Friends" screen when running the app on a device with iPadOS 18 and Xcode 16.

This issue appears to be caused by layout changes introduced in iPadOS 18, where the tab bar is now at the top of the screen. By calling setNavigationBarHidden in viewDidAppear instead of viewWillAppear, we ensure that the layout has been fully constructed, which prevents the UINavigationBar from incorrectly overlaying the content.

🛠 How

The setNavigationBarHidden function was moved from viewWillAppear to viewDidAppear so that the layout is fully built before manipulating the visibility of the navigation bar. This change resolves the layout issue observed in iPadOS 18.

👀 See

Jira issue

Before 🐛	After 🦋

✅ Acceptance criteria

• Ensure the UINavigationBar no longer overlays the "Follow Friends" screen on iPadOS 18.

[ifosli]

Nice!