Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[MBL-1780] Remove deleted method from our beta changelog #2173

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Conversation

ifosli
Copy link
Contributor

@ifosli ifosli commented Oct 10, 2024

📲 What

Update beta-changelog.rb to using File.exist instead of File.exists, as the latter no longer exists in Ruby 3.3.

🤔 Why

I think this will unblock the beta build getting uploaded. The full Ruby error also includes a warning to aws-sdk-core about a change that's happening in Ruby 3.4, but I'm ignoring this for now. I think the fix for that warning is to update our aws gem versions, but I'd rather not do that without understanding what they're doing so I can test the changes properly, and I don't expect a ruby warning to break the script.

👀 See

Jira

✅ Acceptance criteria

  • Tests pass
  • I'm not testing that the beta build works before merging this pr, since I'm not sure how. (I tried creating a pr in the private repo instead, but it looks like the beta build only gets created after submit.) Plus, this pr is definitely part of the solution so I see no harm in confirming if it's the entire solution after it's submitted.

@ifosli ifosli self-assigned this Oct 10, 2024
@ifosli ifosli added the iOS 18 label Oct 10, 2024
@ifosli ifosli marked this pull request as ready for review October 10, 2024 15:52
@ifosli ifosli merged commit 50e19fe into main Oct 10, 2024
4 checks passed
@ifosli ifosli deleted the betaFixes branch October 10, 2024 16:55
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants