[MBL-2063] Delete PledgeViewController & PledgeViewModel #2271
Conversation
| @@ -638,7 +638,6 @@ public final class ProjectPageViewController: UIViewController, MessageBannerVie | |||
| } | |||
|
|
|||
| private func goToRewards(project: Project, refTag: RefTag?) { | |||
| /// Render rewards carousel that has the shipping location dropdown | |||
There was a problem hiding this comment.
Removing this comment. It's no longer needed now that the no-shipping flow is the standard.
| @@ -538,7 +538,6 @@ final class ManagePledgeViewController: UIViewController, MessageBannerViewContr | |||
| // MARK: - Functions | |||
|
|
|||
| private func goToRewards(_ project: Project) { | |||
| /// Render rewards carousel that has the shipping location dropdown | |||
There was a problem hiding this comment.
Removing this comment. It's no longer needed now that the no-shipping flow is the standard.
| @@ -23,7 +23,7 @@ final class RewardAddOnSelectionNoShippingViewController: UIViewController { | |||
| |> \.delegate .~ self | |||
| }() | |||
|
|
|||
| public weak var pledgeViewDelegate: PledgeViewControllerDelegate? | |||
| public weak var pledgeViewDelegate: NoShippingPledgeViewControllerDelegate? | |||
There was a problem hiding this comment.
After I remove all of the legacy classes, I'll rename everything to remove the "NoShipping" preface.
| private func goToPledge(data _: PledgeViewData) { | ||
| // TODO: This class will be removed as part of our legacy checkout cleanup | ||
|
|
||
| self.navigationController?.pushViewController(vc, animated: true) | ||
| // let vc = PledgeViewController.instantiate() | ||
| // vc.delegate = self.pledgeViewDelegate | ||
| // vc.configure(with: data) | ||
| // | ||
| // self.navigationController?.pushViewController(vc, animated: true) |
There was a problem hiding this comment.
Simply commenting out this use of PledgeViewController for now since this class, RewardAddOnSelectionViewController, is a legacy class and will be deleted.
| // TODO: This class will be removed as part of our legacy checkout cleanup | ||
|
|
||
| self.navigationController?.pushViewController(pledgeViewController, animated: true) | ||
| // let pledgeViewController = PledgeViewController.instantiate() | ||
| // pledgeViewController.delegate = self.pledgeViewDelegate | ||
| // pledgeViewController.configure(with: data) | ||
| // | ||
| // self.navigationController?.pushViewController(pledgeViewController, animated: true) |
There was a problem hiding this comment.
Same here. RewardsCollectionViewController, is a legacy class and will be deleted. Simply commenting this code out for now.
scottkicks
force-pushed
the
scott/mbl-2063
branch
from
b80396d to
521ed14
Compare
Generated by 🚫 Danger |
|
closing so I can cleanup the commit history a bit |
📲 What
Also deletes PledgeViewController Snapshots
🤔 Why
Now that the "No Shipping" flow has been made the standard, we can start removing the legacy checkout classes.
Doing this class by class for easier reviews and simpler commits.
🛠 How
👀 See
No visible changes
✅ Acceptance criteria