Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[MBL-2102] Ineligible badge showing USD instead of EUR for EUR-based projects #2280

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

jovaniks
Copy link
Contributor

📲 What

This PR addresses an issue where the Ineligible badge on EUR projects incorrectly displayed the amount in USD instead of EUR. The badge should now reflect the correct currency based on the project’s currency.

🛠 How

Update the hardcoded string and set the projectFragment.pledgeOverTimeMinimumExplanation instead.

👀 See

Ticket

Before 🐛 After 🦋
IMG_A7543825707E-1 image

✅ Acceptance criteria

  • The Ineligible badge now correctly displays the amount in EUR for EUR-based projects.
  • No other currency formatting issues exist for the Ineligible badge.
  • Test cases PASSED

⏰ TODO

  • Create Unit Test for EUR projects

@jovaniks jovaniks self-assigned this Feb 11, 2025
@jovaniks jovaniks changed the title Mapping projectFragment.pledgeOverTimeMinimumExplanation [MBL-2102] Ineligible badge showing USD instead of EUR for EUR-based projects Feb 11, 2025
Copy link
Contributor

@scottkicks scottkicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@jovaniks jovaniks merged commit 09bd045 into main Feb 11, 2025
5 checks passed
@jovaniks jovaniks deleted the jluna/MBL-2102/ineligible-badge-eur branch February 11, 2025 22:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants