[MBL-2110] [MBL-2113] Fixes for PPO analytics events #2289
Merged
+154
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Two fixes:
🤔 Why
🛠 How
combineLatest
, this was changed to aflatMap
+first
. This causes the Paginator's results method to fire immediately, and only one time. Since this is a flatMap, this process repeats every time the flatMap happens (e.g. every time the relevant button is clicked). This gets us the behavior we need.confirmed
, when the user has confirmed their intent but processing is still happening.