[MBL-2120] PLOT - Fixing issue when device locate is ES #2297

jovaniks · 2025-02-19T20:56:49Z

📲 What

This PR addresses the currency formatting issue in the Checkout Screen and Manage Pledge screens by using amountFormattedInProjectNativeCurrency for correctly formatted amounts and mapping amountAsFloat to a new string-based field for accurate display in attributed text.

🤔 Why

The backend returns values with decimals expressed using a comma (,) instead of a dot (.) for some locales, causing incorrect currency formatting.
amountAsFloat is inconsistent across different regional settings, leading to UI issues when displaying amounts.
The Manage Pledge screen requires an attributed string format to display the currency symbol and cents correctly, which amountAsFloat alone cannot handle.

🛠 How

amountAsFloat is mapped to a new field: PledgePaymentIncrementAmount.amountStringValue (String type).
Checkout Screen: Now uses amountFormattedInProjectNativeCurrency to ensure the correct format without additional parsing.
Manage Pledge Screen:
- Created a new function attributedCurrency to handle attributed string formatting for currency values.
- Added parseAmountComponents to extract integer, decimal separator, and decimal part from amountStringValue for proper UI display.

👀 See

Before 🐛	After 🦋

✅ Acceptance criteria

Ensure Checkout Screen correctly displays formatted values.
Verify Manage Pledge screen displays amounts using attributed strings with correct font sizes.

⏰ TODO

Consider refactoring all currency formatting to rely on server-formatted values in the future.

amy-at-kickstarter

I have a question about the expected server behavior before I can continue reviewing this code.

amy-at-kickstarter · 2025-02-19T21:27:56Z

Library/Format.swift

+  /// - Returns: An `NSAttributedString` where the currency symbol and decimals are displayed in a smaller font.
+  ///            If the amount cannot be parsed, it returns the amount as a plain attributed string.
+  public static func attributedCurrency(
+    amountString: String,


Question. amountString will be set to the amountAsFloat sent from the server, correct? Why would amountAsFloat include any regional formatting, like comma separators? My assumption would be that the server should be sending a 'plain' string like "2499.75", not "2,499.75".

@lukert33 can you clarify the server's behavior here?

That's correct, amountString takes its value from amountAsFloat. I feel like amountAsFloat represents a money format without currency symbols.

GraphQL response:

Huh, that's not what I would have expected. Surprising.

scottkicks · 2025-02-19T22:16:31Z

Library/Format.swift

Can you link the ticket that will address cleaning these format helpers up once the backend is updated to give us the correct formatted string as well?

scottkicks · 2025-02-19T22:21:22Z

...CurrentUser_IsBacker_PledgeOverTime_PaymentSchedule_Expanded.lang_de_device_phone4_7inch.png

I'm not seeing what's changed in these snapshots 🤔

scottkicks

Good work. Looking forward to having the server handle this for us so we dont have to do so much formatting client side

…Currency` to represents the amounts in all of the PLOT stuff related

jovaniks

PLOT UI now fully uses amountFormattedInProjectNativeCurrency for amounts.

jovaniks · 2025-02-20T00:09:47Z

...CurrentUser_IsBacker_PledgeOverTime_PaymentSchedule_Expanded.lang_de_device_phone4_7inch.png

Snapshots updated since the increments amounts are using a plain text instead of a attributed text

jovaniks · 2025-02-20T00:11:14Z

Library/ViewModels/PledgeOverTimePaymentScheduleViewModel.swift

@@ -84,38 +84,12 @@ public struct PLOTPaymentScheduleItem: Equatable {
      timeStyle: .none
    )

+    self.amountString = increment.amount.amountFormattedInProjectNativeCurrency


Set amountFormattedInProjectNativeCurrency directly to have a plain text in the UILabel

jovaniks · 2025-02-20T00:41:28Z

Kickstarter-iOS/Features/ManagePledge/Controllers/ManagePledgeViewController.swift

-          with: increments,
-          project: project
-        )
+      .observeValues { [weak self] increments in


Removed project since it is not more necessary

jovaniks · 2025-02-20T00:42:49Z

...rter-iOS/Features/ManagePledge/Controllers/PledgeOverTimePaymentScheduleViewController.swift

@@ -100,7 +100,7 @@ final class PledgeOverTimePaymentScheduleViewController: UIViewController {
      itemView.configure(
        with: item.dateString,
        badgeTitle: item.stateLabel,
-        amountAttributedText: item.amountAttributedText,
+        amountString: item.amountString,


Use a string instead of a attributedText due the UI is showing a plain text

jovaniks · 2025-02-20T00:44:23Z

...CurrentUser_IsBacker_PledgeOverTime_PaymentSchedule_Expanded.lang_de_device_phone4_7inch.png

Snapshots updated due the amount labels are using a plain text instead of a attributed text with currency symbols and decimals with smaller size and offset

jovaniks · 2025-02-20T00:45:07Z

KsApi/fragments/PaymentIncrementFragment.graphql

@@ -1,6 +1,5 @@
 fragment PaymentIncrementFragment on PaymentIncrement {
  amount {
-    amountAsFloat


We don't need amountAsFloat anymore

amy-at-kickstarter

LGTM! Thanks for reworking this.

There are two follow-up tickets from this PR:

https://kickstarter.atlassian.net/browse/PAY-3468
https://kickstarter.atlassian.net/browse/MBL-2123

* Fixing issue when device locate is ES * Fixing test * Removing `amountAsFloat` and only use `amountFormattedInProjectNativeCurrency` to represents the amounts in all of the PLOT stuff related * Remove unused Project reference

* marketing version to 5.23.0 * [MBL-2120] PLOT - Fixing issue when device locate is ES (#2297) * Fixing issue when device locate is ES * Fixing test * Removing `amountAsFloat` and only use `amountFormattedInProjectNativeCurrency` to represents the amounts in all of the PLOT stuff related * Remove unused Project reference --------- Co-authored-by: jovaniks <j.luna.c@kickstarter.com>

Fixing issue when device locate is ES

d557e15

jovaniks requested review from scottkicks and amy-at-kickstarter February 19, 2025 20:56

jovaniks self-assigned this Feb 19, 2025

Fixing test

6f12363

amy-at-kickstarter reviewed Feb 19, 2025

View reviewed changes

scottkicks reviewed Feb 19, 2025

View reviewed changes

scottkicks approved these changes Feb 19, 2025

View reviewed changes

jovaniks added 2 commits February 19, 2025 16:07

Removing amountAsFloat and only use `amountFormattedInProjectNative…

9820adc

…Currency` to represents the amounts in all of the PLOT stuff related

Remove unused Project reference

f3f9a98

jovaniks commented Feb 20, 2025

View reviewed changes

jovaniks requested review from scottkicks and amy-at-kickstarter February 20, 2025 00:47

amy-at-kickstarter approved these changes Feb 20, 2025

View reviewed changes

scottkicks approved these changes Feb 20, 2025

View reviewed changes

Merge branch 'main' into jluna/MBL-2120/plot-decimal-issue

2fbae71

jovaniks merged commit ebb2c32 into main Feb 20, 2025
5 checks passed

jovaniks deleted the jluna/MBL-2120/plot-decimal-issue branch February 20, 2025 16:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MBL-2120] PLOT - Fixing issue when device locate is ES #2297

[MBL-2120] PLOT - Fixing issue when device locate is ES #2297

jovaniks commented Feb 19, 2025

amy-at-kickstarter left a comment

amy-at-kickstarter Feb 19, 2025

jovaniks Feb 19, 2025

amy-at-kickstarter Feb 19, 2025

scottkicks Feb 19, 2025 •

edited

Loading

scottkicks Feb 19, 2025

scottkicks left a comment

jovaniks left a comment

jovaniks Feb 20, 2025

jovaniks Feb 20, 2025

jovaniks Feb 20, 2025

jovaniks Feb 20, 2025

jovaniks Feb 20, 2025

jovaniks Feb 20, 2025

amy-at-kickstarter left a comment

[MBL-2120] PLOT - Fixing issue when device locate is ES #2297

[MBL-2120] PLOT - Fixing issue when device locate is ES #2297

Conversation

jovaniks commented Feb 19, 2025

📲 What

🤔 Why

🛠 How

👀 See

✅ Acceptance criteria

⏰ TODO

amy-at-kickstarter left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

scottkicks Feb 19, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

scottkicks left a comment

Choose a reason for hiding this comment

jovaniks left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

amy-at-kickstarter left a comment

Choose a reason for hiding this comment

scottkicks Feb 19, 2025 •

edited

Loading