Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
count
is used in a message, but not passed as a variable, it should provide a meaningful default.I'm not really sure why you would want to implement a plural message without a
count
argument, but the tests didn't really make sense:assert.equal("Une chose.", i18n('message', {count = 0}))
is clearly incorrect, as while0
is in the same CLDR plural category as1
in French, it doesn't mean the same thing. So without the ability to match against numerical constants in addition to CLDR plural categories, it only works to have the message be:But then the
defaults to 1
test producesnil chose.
, which isn't helpful, so we need a default value forcount
as well as a default plural category for it.