fix(upgrade): Make pinned skipping the default

README.md

@@ -154,9 +154,7 @@ OPTIONS:
         --manifest-path <PATH>    Path to the manifest to upgrade
         --offline                 Run without accessing the network
     -p, --package <PKGID>         Package id of the crate to add this dependency to
-        --skip-pinned             Only update a dependency if it is not currently pinned in the
-                                  manifest. "Pinned" refers to dependencies with a '=' or '<' or
-                                  '<=' version requirement
+        --pinned                  Upgrade dependencies pinned in the manifest
         --to-lockfile             Upgrade all packages to the version in the lockfile
     -v, --verbose                 Use verbose output
     -V, --version                 Print version information

src/bin/upgrade/upgrade.rs

@@ -67,10 +67,9 @@ pub struct UpgradeArgs {
     #[clap(long)]
     dry_run: bool,
 
-    /// Only update a dependency if it is not currently pinned in the manifest.
-    /// "Pinned" refers to dependencies with a '=' or '<' or '<=' version requirement
+    /// Upgrade dependencies pinned in the manifest.
     #[clap(long)]
-    skip_pinned: bool,
+    pinned: bool,
 
     /// Run without accessing the network
     #[clap(long)]
@@ -207,7 +206,7 @@ fn exec(args: UpgradeArgs) -> CargoResult<()> {
                         continue;
                     }
                 };
-                if args.skip_pinned {
+                if !args.pinned {
                     if dependency.rename.is_some() {
                         args.verbose(|| {
                             shell_warn(&format!(

tests/cmd/upgrade/exclude_dep.toml

@@ -1,5 +1,5 @@
 bin.name = "cargo-upgrade"
-args = ["upgrade", "--exclude", "docopt", "--verbose"]
+args = ["upgrade", "--pinned", "--exclude", "docopt", "--verbose"]
 status = "success"
 stdout = ""
 stderr = """

tests/cmd/upgrade/exclude_renamed.out/Cargo.toml

@@ -6,7 +6,7 @@ version = "0.0.0"
 path = "dummy.rs"
 
 [dependencies]
-te = { package = "toml_edit", version = "99999.0.0" }
+te = { package = "toml_edit", version = "0.1.5" }
 
 [dependencies.rx]
 package = "regex"

tests/cmd/upgrade/exclude_renamed.toml

@@ -4,7 +4,7 @@ status = "success"
 stdout = ""
 stderr = """
     Checking cargo-list-test-fixture's dependencies
-   Upgrading te: v0.1.5 -> v99999.0.0
+warning: ignoring te, renamed dependencies are pinned
 warning: ignoring rx, excluded by user
 """
 fs.sandbox = true

tests/cmd/upgrade/skip_pinned.toml → tests/cmd/upgrade/pinned.toml

@@ -1,5 +1,5 @@
 bin.name = "cargo-upgrade"
-args = ["upgrade", "--skip-pinned", "--verbose"]
+args = ["upgrade", "--verbose"]
 status = "success"
 stdout = ""
 stderr = """

tests/cmd/upgrade/preserve_precision_major.toml

@@ -1,5 +1,5 @@
 bin.name = "cargo-upgrade"
-args = ["upgrade", "--verbose"]
+args = ["upgrade", "--pinned", "--verbose"]
 status = "success"
 stdout = ""
 stderr = """

tests/cmd/upgrade/preserve_precision_minor.toml

@@ -1,5 +1,5 @@
 bin.name = "cargo-upgrade"
-args = ["upgrade", "--verbose"]
+args = ["upgrade", "--pinned", "--verbose"]
 status = "success"
 stdout = ""
 stderr = """

tests/cmd/upgrade/preserve_precision_patch.toml

@@ -1,5 +1,5 @@
 bin.name = "cargo-upgrade"
-args = ["upgrade", "--verbose"]
+args = ["upgrade", "--pinned", "--verbose"]
 status = "success"
 stdout = ""
 stderr = """

tests/cmd/upgrade/upgrade_everything.toml

@@ -1,5 +1,5 @@
 bin.name = "cargo-upgrade"
-args = ["upgrade"]
+args = ["upgrade", "--pinned"]
 status = "success"
 stdout = ""
 stderr = """

tests/cmd/upgrade/upgrade_renamed.toml

@@ -1,5 +1,5 @@
 bin.name = "cargo-upgrade"
-args = ["upgrade", "--verbose"]
+args = ["upgrade", "--pinned", "--verbose"]
 status = "success"
 stdout = ""
 stderr = """