Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Renaming definitions without disrupting integrity #35

Open
geoffroy-noel-ddh opened this issue Sep 1, 2023 · 1 comment
Open

Renaming definitions without disrupting integrity #35

geoffroy-noel-ddh opened this issue Sep 1, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request MUST

Comments

@geoffroy-noel-ddh
Copy link
Member

Check if changing the name of an allograph should be allowed.

The issue here is that the key won't be changed (b/c it might be used in annotation descriptions) and might therefore:

  1. be misleading
  2. clash with new allograph

Maybe the best would be to delete & recreated the allograph? But then what happens to associated CF & annotations?

As a test we should check that:

  1. key is not already take and generate variant if needed
  2. test suspicious keys which are too different from their label/character

Also check the same principles with script, component and feature.

In general correcting a typo in a script or component/feature is ok. But renaming Latin to Greek or A to B is looking for trouble.

@geoffroy-noel-ddh geoffroy-noel-ddh self-assigned this Sep 1, 2023
@geoffroy-noel-ddh geoffroy-noel-ddh added enhancement New feature or request MUST labels Sep 1, 2023
@geoffroy-noel-ddh geoffroy-noel-ddh changed the title Changing definition names Renaming definitions without disrupting integrity Sep 1, 2023
@simonastoyanova
Copy link
Collaborator

I have a case for renaming two features: touching and not-touching to attached and detached. I have used them in numerous annotations, so if we do decide to rename them, basically it should be a find and replace of those two words within the whole repository. Happy to discuss in a call and decide how best to do it.

geoffroy-noel-ddh added a commit that referenced this issue Aug 5, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request MUST
Projects
None yet
Development

No branches or pull requests

2 participants