Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Move strt/stop/step config to its own function #447

Merged

Conversation

dcslagel
Copy link
Collaborator

@dcslagel dcslagel commented Apr 16, 2021

Description:

This is part of Remove side-effects from write() #268 but not the whole task.

Move strt/stop/step config/change from writer.py::write() to its own function as part of the LASFile class: update_start_stop_step()

For this checkin, las.update_start_stop_step() is included in writer.py::write() so the overall behavior is the same.

Test Results:

Name                       Stmts   Miss  Cover
----------------------------------------------
lasio/__init__.py             13      2    85%
lasio/convert_version.py      20     20     0%
lasio/defaults.py             11      0   100%
lasio/examples.py             42     10    76%
lasio/excel.py                88     34    61%
lasio/exceptions.py            6      0   100%
lasio/las.py                 428     60    86%
lasio/las_items.py           199     29    85%
lasio/las_version.py          50     14    72%
lasio/reader.py              396     25    94%
lasio/writer.py              159      9    94%
----------------------------------------------
TOTAL                       1412    203    86%
Coverage XML written to file coverage.xml

--

Let me know if this change could be accepted (or rejected) or
needs some additional changes to be approved and merged.

Thank you,
DC

Move strt/stop/step config/change from writer.py::write() to its own
function as part of the LASFile class. For this checkin this new
function is included in writer.py::write() so the overall behavior
is the same.
@kinverarity1 kinverarity1 merged commit bd7dc90 into kinverarity1:master Apr 17, 2021
@dcslagel dcslagel deleted the writer-code-mv-step-cfg-to-func branch April 17, 2021 06:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants