Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

When excess curves defined in ~C, add null data and emit warning #480

Merged
merged 4 commits into from
Jul 15, 2021

Conversation

kinverarity1
Copy link
Owner

This PR fixes #83. Changes:

In LASFile.read, while we are assigning data to curves, we keep track of which curve indexes have had data assigned. Afterwards we iterate over all curve indices and for any that did not have data assigned we:

  • emit a logger.warning message
  • assign a data array full of np.nan values

@kinverarity1 kinverarity1 requested a review from dcslagel July 14, 2021 07:00
Copy link
Collaborator

@dcslagel dcslagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'll go ahead and merge it.

@dcslagel dcslagel merged commit 25ed797 into master Jul 15, 2021
@kinverarity1
Copy link
Owner Author

Thanks!

@kinverarity1 kinverarity1 deleted the excess-curves-defined branch July 15, 2021 11:08
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LAS file with more curves defined in ~C section than available in ~A section
2 participants