Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add TRACE_LASIO logging level #484

Merged
merged 2 commits into from
Jul 16, 2021
Merged

Add TRACE_LASIO logging level #484

merged 2 commits into from
Jul 16, 2021

Conversation

kinverarity1
Copy link
Owner

  • Adds add_logging_level(level_name, level) function from https://stackoverflow.com/a/35804945/596328 (authored by
    Mad Physicist)
  • Adds TRACE_LASIO logging level
  • Adds Logger.trace_lasio(message) method
  • Changes the logger.debug call done for each line in the data section to a logger.trace_lasio call.

Refer to issue #483

- Adds add_logging_level(level_name, level) function from
  https://stackoverflow.com/a/35804945/596328 (authored by
  Mad Physicist)
- Adds TRACE_LASIO logging level
- Adds trace_lasio(message) method to Logger
- Changes the logger.debug call done for each line in the data section
  to a logger.trace_lasio call.

Refer to issue #483
@kinverarity1 kinverarity1 merged commit 36bc774 into master Jul 16, 2021
@kinverarity1 kinverarity1 deleted the logging branch July 16, 2021 07:19
@dcslagel
Copy link
Collaborator

It looks like the test coverage for lasio/init.py drops significantly with this merge due to the new AttributeErrors and Logging. Do we want to add coverage for these changes?

before:

Name                       Stmts   Miss  Cover
----------------------------------------------
lasio/__init__.py              8      0   100%

after:

Name                       Stmts   Miss  Cover
----------------------------------------------
lasio/__init__.py             28      6    79%

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants