internal review #27
Open
internal review #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giuseppe
reviewed
Feb 1, 2023
rata
force-pushed
the
rata/userns
branch
9 times, most recently
from
734207a
to
a61d587
Compare
rata
changed the base branch from
master
to
dependabot/go_modules/github.com/go-playground/validator/v10-10.12.0
rata
changed the base branch from
dependabot/go_modules/github.com/go-playground/validator/v10-10.12.0
to
master
giuseppe
reviewed
Jan 11, 2024
mrunalp
reviewed
Jan 16, 2024
rata
force-pushed
the
rata/userns
branch
6 times, most recently
from
cca967f
to
0a9ec5c
Compare
Signed-off-by: Rodrigo Campos <rodrigoca@microsoft.com>
Signed-off-by: Rodrigo Campos <rodrigoca@microsoft.com>
Signed-off-by: Rodrigo Campos <rodrigoca@microsoft.com> Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Signed-off-by: Rodrigo Campos <rodrigoca@microsoft.com>
So it is rendered properly on github. Signed-off-by: Rodrigo Campos <rodrigoca@microsoft.com>
Signed-off-by: Rodrigo Campos <rodrigoca@microsoft.com>
giuseppe
force-pushed
the
rata/userns
branch
3 times, most recently
from
91377aa
to
d7e437c
Compare
Signed-off-by: Rodrigo Campos <rodrigoca@microsoft.com> Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Co-authored-by: Giuseppe Scrivano <gscrivan@redhat.com> Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com> Signed-off-by: Rodrigo Campos <rodrigoca@microsoft.com>
Signed-off-by: Rodrigo Campos <rodrigoca@microsoft.com> Signed-off-by: Peter Hunt <pehunt@redhat.com>
haircommander
force-pushed
the
rata/userns
branch
from
f688ef1
to
b64d85b
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @giuseppe
Reviewing commit by commit, or just reading the end file might be simpler than the diff