feat: add secure cookie based auth #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
10 Skipped Deployments
|
Isti01
reviewed
Sep 8, 2024
| @@ -28,6 +28,7 @@ class WebMvcConfig( | |||
| arrayOf("/api/**", "/manifest/**", "/cdn/**").forEach { | |||
| registry.addMapping(it) | |||
| .allowedOrigins(productionUrl) | |||
| .allowCredentials(true) | |||
There was a problem hiding this comment.
These are public endpoints, but it shouldn't hurt
There was a problem hiding this comment.
Yes, but the request fill fail if there are credentials provided
Isti01
approved these changes
Sep 8, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR approved, the backend will start to set cookies for the domain from the site url, making cookies HTTP only and Secure, removing the need to manually get the JWT from the query param and state manage from there.
I made sure to handle the refresh mechanism for Create & Edit team flows as well as form submission.
Logout works as well by setting the cookie to null.