Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove GO111MODULE: 'off' variantes from CI workflow #221

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Remove GO111MODULE: 'off' variantes from CI workflow #221

merged 1 commit into from
Jan 11, 2023

Conversation

kisielk
Copy link
Owner

@kisielk kisielk commented Jan 11, 2023

No description provided.

@kisielk kisielk requested review from echlebek and dtcaciuc January 11, 2023 18:36
@kisielk kisielk mentioned this pull request Jan 11, 2023
Merged
echlebek
echlebek approved these changes Jan 11, 2023
View reviewed changes
Copy link
Collaborator

@echlebek echlebek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth making a note about this in the readme, as errcheck used to work without modules, but now, doesn't.

@kisielk kisielk merged commit c2c614f into master Jan 11, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@echlebek echlebek echlebek approved these changes

@dtcaciuc dtcaciuc Awaiting requested review from dtcaciuc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kisielk @echlebek