Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Python2, package requirements requirement for OpenWRT packages? #7

Open
kitchung opened this issue Jul 20, 2021 · 3 comments
Open

Python2, package requirements requirement for OpenWRT packages? #7

kitchung opened this issue Jul 20, 2021 · 3 comments

Comments

@kitchung
Copy link

Do we actually need python2 and the python3-cython and python3-numpy (v1.19.1) packages?

The Makefiles RTLSDR capture packages for Kismet along with Python packages (cython, numpy, protobuf websocket) have the following denoting the dependencies for both Python 2.x and 3.x:

include $(TOPDIR)/feeds/packages/lang/python/python-package.mk
include $(TOPDIR)/feeds/packages/lang/python/python3-package.mk

The Setup.py for the these capture packages have only a dependency for Python >=3.2:
python_requires='>=3.2',

OpenWRT currently supports Python3 with Python2 moved to https://github.com/openwrt/packages-abandoned

I've successfully in compiled for for openWRT-21.02 after commenting out the need for python-package.mk:

  • RTLSDRcapture packages
  • python3-protobuf
  • python3-websockets

python3-cython never became a dependency for me and I used python3-numpy from OpenWRT's feed instead.

Am i missing anything by commenting out python3, using OpenWRT's python3-numpy (v1.20.2) package and not compiling this repo's python3-cython?

Caveat: I'm a beginner with Kismet and intermediate in building software.

@kitchung
Copy link
Author

Can the python2 dependencies be removed since it appears to be resolved with the commits cited in kismetwireless/kismet#159?

@kismetwireless
Copy link
Owner

kismetwireless commented Jul 20, 2021 via email

@kitchung
Copy link
Author

Looks like you took care of this via this commit? 5e5ee69

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants