-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Enrich process with LABEL and ORDERLABEL during mass import #6143
Enrich process with LABEL and ORDERLABEL during mass import #6143
Conversation
Thanks a lot! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good and works. Thanks a lot for the test.
@andre-hohmann did you have a chance to check whether the changes in this pull request do indeed solve some issues, as you anticipated? |
Kitodo/src/test/java/org/kitodo/production/services/data/ImportServiceIT.java
Outdated
Show resolved
Hide resolved
@BartChris please rebase your branch against the current master and update your test to use Junit5 instead of Junit4, for which support has been removed in the master branch now. |
87000f2
to
7a82c53
Compare
@solth done |
@solth : I am sorry, but i did not read the description of the pull request correctly. I thought, that the export is modified in the way that |
Because of the way Kitodo production works, it is important to have the LABEL and the ORDERLABEL before the data is exported and partially enriched via XSL.
#5016 (comment)
This is especially a problem when providing LABELs during mass import, because an import XSL does not take into consideration fields provided via csv upload.
This PR explicitely adds LABEL and ORDERLABEL to the logical root, when they are provided during mass import.