Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Enrich process with LABEL and ORDERLABEL during mass import #6143

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

BartChris
Copy link
Collaborator

@BartChris BartChris commented Jul 24, 2024

Because of the way Kitodo production works, it is important to have the LABEL and the ORDERLABEL before the data is exported and partially enriched via XSL.
#5016 (comment)
This is especially a problem when providing LABELs during mass import, because an import XSL does not take into consideration fields provided via csv upload.

This PR explicitely adds LABEL and ORDERLABEL to the logical root, when they are provided during mass import.

@andre-hohmann
Copy link
Collaborator

Thanks a lot!
If that PR works, it will solve a lot of problems!
Especially if you want to want to modify the ORDER and ORDERLABEL for periodical volumes - which is what we do.
Good luck!

Copy link
Member

@solth solth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and works. Thanks a lot for the test.

@solth solth added this to the Kitodo.Production 3.7.0 milestone Jul 30, 2024
@solth
Copy link
Member

solth commented Jul 31, 2024

@andre-hohmann did you have a chance to check whether the changes in this pull request do indeed solve some issues, as you anticipated?

@solth
Copy link
Member

solth commented Jul 31, 2024

@BartChris please rebase your branch against the current master and update your test to use Junit5 instead of Junit4, for which support has been removed in the master branch now.

@BartChris BartChris force-pushed the label_and_orderlabel_in_mass_import branch from 87000f2 to 7a82c53 Compare July 31, 2024 14:56
@BartChris
Copy link
Collaborator Author

@solth done

@andre-hohmann
Copy link
Collaborator

@andre-hohmann did you have a chance to check whether the changes in this pull request do indeed solve some issues, as you anticipated?

@solth : I am sorry, but i did not read the description of the pull request correctly. I thought, that the export is modified in the way that <mets:structMap TYPE="LOGICAL"> of superordinate processes is created after the export XSLT is applied to the subordinate processes.
Thus, the modification of the mass import does not solve issues i anticipated.

@solth solth merged commit faf1085 into kitodo:master Aug 1, 2024
5 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants