Skip to content

Remove redundant class variable definition from recipes #2938

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Remove redundant class variable definition from recipes #2938

wants to merge 2 commits into from

Conversation

shyamnathp
Copy link
Contributor

  • Some of the variables like call_hostpython_via_targetpython, install_in_hostpython are redifined in the package recipes with the exact same value as its parent class, making the definitions redundant. This patch removes these redefinitions.

@ShyamQt
Remove redundant veriable definition from recipes
5f0b46b 
- Some of the variables like call_hostpython_via_targetpython,
  install_in_hostpython are redifined in the package recipes with
  the exact same value as its parent class, making the definitions
  redundant. This patch removes this redefinitions.
@shyamnathp
Copy link
Contributor Author

feel free to abandon this PR if the variables were redefined originally for readability reasons.

@misl6
Copy link
Member

misl6 commented Dec 8, 2023

Thanks for the cleanup @shyamnathp , however, the CI is failing.

The good news is that I'm 100% sure is not your fault, but in order to have a ✅ , can you please add pygame to this list ?

@shyamnathp
Copy link
Contributor Author

Thanks for the cleanup @shyamnathp , however, the CI is failing.

The good news is that I'm 100% sure is not your fault, but in order to have a ✅ , can you please add pygame to this list ?

As a part of understanding the logs, how did you figure out it was 'pygame' that was causing the crash? From the logs, I see liblzma seems to be the culprit and this does not seem to be a dependent recipe of 'pygame'

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
recipe
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shyamnathp @misl6 @kuzeyron @ShyamQt