-
Notifications
You must be signed in to change notification settings - Fork 1.9k
scipy: update to v1.15.2 #3136
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: develop
Are you sure you want to change the base?
scipy: update to v1.15.2 #3136
Conversation
SDL does not builds with ndk CC: @misl6 |
Will continue working on the SDL3 recipes this weekend, however we are going to support both SDL2 and SDL3 for a long time, as only Kivy 3.0.0 will support SDL3, and will not be ready quite soon. Maybe we can use NDK 27 only for some specific recipes? (or a previous one for SDL2) |
Just saw fixed was also pushed for SDL2, so bumped version to include that fix. :) |
5e09b20
to
48a215a
Compare
df40a87
to
b972e5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Impressive work so far!
Thanks for picking this up too @T-Dynamos 🙏
Maybe it's a good time to rebase it since SDL3 (#3125) was merged
Should I document this things or add warnings in code:
|
a8d8c9b
to
bce0f13
Compare
Yeah maybe failing early with an explicit message would do it, what do you think? |
if line.split("#!")[-1].strip() == original_bin: | ||
return | ||
|
||
info(f"Fixing sheband for '{_file}'") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shebang*
Closes #3116
Cons:
Extra Notes:
Removes need to use
LEGACY_NDK
as it uses fortran from https://github.com/termux/ndk-toolchain-clang-with-flang.