Sarka/playroom snippets #4583
Merged
Sarka/playroom snippets #4583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarkaaa
changed the base branch from
master
to
devin/1736720770-playroom-setup
![callstackai[bot]](https://avatars.githubusercontent.com/in/1040204?s=60&v=4){kind=small}
|
Storybook staging is available at https://kiwicom-orbit-sarka-playroom-snippets.surge.sh |
|
Size Change: 0 B Total Size: 459 kB
ℹ️ View Unchanged
|
Deploying orbit with
|
| Latest commit: |
43065b9
|
| Status: | ⚡️ Build in progress... |
DSil
reviewed
Jan 17, 2025
|
|
||
| const loading = `<Loading loading text="Please wait, content is loading..." type="pageLoader" />`; | ||
|
|
||
| const navigationBar = ` |
There was a problem hiding this comment.
This should be on Layouts file, imo
There was a problem hiding this comment.
yeah, I was thinking about it as well. PR is just a draft for now.
Comment on lines
123
to
127
| id="navigation-menu-id" | ||
| // onHide={function()} | ||
| // onMenuOpen={function()} | ||
| // onShow={function()} | ||
| openTitle="Open navigation menu" |
There was a problem hiding this comment.
We can delete all these lines, keep it simple
| </Popover> | ||
| `; | ||
|
|
||
| const radio = `<Radio label="Label" name="Name" tabIndex={0} value="value" />`; |
There was a problem hiding this comment.
Suggested change
| const radio = `<Radio label="Label" name="Name" tabIndex={0} value="value" />`; | |
| const radio = `<Radio label="Label" name="Name" value="value" />`; |
| spacing="100" | ||
| > | ||
| <ButtonLink | ||
| aria-label="Favourites" |
There was a problem hiding this comment.
No need to have aria-label here
| icon={<Icons.Accommodation />} | ||
| role="list" | ||
| selectable | ||
| tabIndex={0} |
There was a problem hiding this comment.
Why this tabIndex? Same for the below one
Comment on lines
77
to
75
| <ListItem> | ||
| 24,000 locations{' '} | ||
| <TextLink href="#"> | ||
| around | ||
| </TextLink> | ||
| {' '}the globe | ||
| </ListItem> |
There was a problem hiding this comment.
We can keep it much simpler by just having some Text, no need for a link or whatever
sarkaaa
force-pushed
the
sarka/playroom-snippets
branch
2 times, most recently
from
46880f0 to
1721892
Compare
|
Changed. I tried to make it as simple as possible. ✨ |
DSil
force-pushed
the
sarka/playroom-snippets
branch
from
1721892 to
43065b9
Compare
DSil
approved these changes
Jan 20, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request meets the following criteria:
For new components:
d.tsfiles and are exported inindex.d.ts✨
Description by Callstackai
This PR introduces new components and their corresponding snippets for use in the playroom, including
LinkList,List,ListChoice,Loading,NotificationBadge,Pagination,Popover,Radio,Seat, andNavigationBar.Diagrams of code changes
sequenceDiagram participant App participant BasicComponents participant Layouts App->>BasicComponents: Add new UI components Note over BasicComponents: Added components:<br/>LinkList<br/>List<br/>ListChoice<br/>Loading<br/>NotificationBadge<br/>Pagination<br/>Popover<br/>Radio<br/>Seat App->>Layouts: Add NavigationBar Note over Layouts: Added NavigationBar with:<br/>- Flight menu<br/>- Star button<br/>- Account buttonFiles Changed