ChoiceGroup accessibility #4636
Merged
+25
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook staging is available at https://kiwicom-orbit-dsil-choicegroup-a11y.surge.sh Playroom staging is available at https://kiwicom-orbit-dsil-choicegroup-a11y.surge.sh/playroom |
|
Size Change: -87 B (-0.02%) Total Size: 461 kB
ℹ️ View Unchanged
|
Deploying orbit with
|
| Latest commit: |
c9a77a2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c58e6a26.orbit.pages.dev |
| Branch Preview URL: | https://dsil-choicegroup-a11y.orbit.pages.dev |
DSil
force-pushed
the
dsil/choicegroup-a11y
branch
from
e7119b9 to
27c509c
Compare
sarkaaa
reviewed
Mar 3, 2025
It was rendering as an h4, causing problems with heading hierarchies
DSil
force-pushed
the
dsil/choicegroup-a11y
branch
from
27c509c to
c9a77a2
Compare
sarkaaa
approved these changes
Mar 3, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The label now renders as a div by default. It was rendering as an h4, causing problems with heading hierarchies
It is still controllable via the
labelAsprop (nothing changed here).Stories were also updated to correctly use Radio component uncontrolled
FEPLT-2260
✨
Description by Callstackai
This PR updates the
ChoiceGroupcomponent to render the label as adivby default instead of anh4, improving accessibility and heading hierarchy. ThelabelAsprop remains unchanged, allowing for flexibility in rendering. Additionally, the stories have been updated to use theRadiocomponent in an uncontrolled manner.Diagrams of code changes
sequenceDiagram participant User participant ChoiceGroup participant Heading participant Radio User->>ChoiceGroup: Render with props (label, labelAs) Note over ChoiceGroup: New labelAs prop support<br/>(h2, h3, h4, h5, h6, div) ChoiceGroup->>Heading: Create heading with labelAs element Heading-->>ChoiceGroup: Rendered heading ChoiceGroup->>Radio: Render Radio buttons Note over Radio: Multiple Radio options<br/>with name, label, value Radio-->>ChoiceGroup: Rendered Radio group ChoiceGroup-->>User: Complete ChoiceGroup renderedFiles Changed
nameprop toRadiocomponents.div.h4todivand updated thelabelAsprop default value.divas a valid option for thelabelAsprop.This PR includes files in programming languages that we currently do not support. We have not reviewed files with the extensions
.md. See list of supported languages.