-
-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: added toc dropup like in Kiwix-PWA #1306
base: main
Are you sure you want to change the base?
Conversation
@heropj Many thanks for this PR. I'm just running tests, and then will do some manual testing. |
Thanks for this PR. I've done some manual testing, and I noticed these issues:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see previous comment for some issues you need to address. Please test the UI fully with different ZIM types and focus on useability. Thanks!
hello @Jaifroid, Thank-you for reviewing and highlighting these issues. fix:
|
Thank you, will test! |
fix #1212
Implemented a fully functional TOC drop-up, inspired by Kiwix-PWA and PR add ToC as in kiwix pwa #1241
When user clicks on drop-up button, TOC List is set up and displayed as drop-up menu.
It is closed when drop-up button loses focus or when a section is clicked.
Clicking a section scrolls the view to that section.