Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

CI: Drop EOL Ruby 2.5, EOL Rails 5.2, add Ruby 3.2 #424

Closed

Conversation

olleolleolle
Copy link

@olleolleolle olleolleolle commented Mar 29, 2023

This PR updates the CI matrix to reflect EOLs.

  • Drop Ruby 2.5
  • Drop Rails 5.2
  • Add Ruby 3.2

@olleolleolle olleolleolle marked this pull request as ready for review March 29, 2023 12:50
@n-rodriguez
Copy link
Collaborator

Hi there! Any news? ping @kjvarga

@n-rodriguez
Copy link
Collaborator

Hi there! Can you please rebase your branch? Be careful, we no longer use CircleCI but GithubActions and we use Appraisal gem to maintain gemfiles/*.

By the way I don't know what is the maintenance policy, so maybe we could also remove Ruby < 3.0 and Rails < 7.0?

What do you think?

cc @kjvarga

Thank you!

@olleolleolle
Copy link
Author

@n-rodriguez #438 does that, I think.

@kjvarga
Copy link
Owner

kjvarga commented Nov 4, 2024

Looks like this PR can be closed in favour of #438. In general I'm okay with focussing integration testing on all supported versions of Ruby and Rails. But the reality is that there's a lot of software running really old versions of everything (our company only recently managed to upgrade an old Rails 4.2 app in the past year lol). So I try to maintain backwards compatibility when it's not onerous to do so.

@olleolleolle olleolleolle deleted the drop-ruby-25-add-ruby-32 branch November 5, 2024 07:46
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants