Fix Ruby "method redefined" warning #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failing integration tests can be fixed by merging #434. |
mattbrictson
changed the title
|
@mattbrictson Hi there! can you please rebase your branch? Thank you! |
When Ruby warnings are enabled, this is printed when loading the sitemap_generator gem: > sitemap_generator-6.3.0/lib/sitemap_generator/templates.rb:16):1: warning: method redefined; discarding old sitemap_sample This is because an attr reader (e.g. `sitemap_sample`) was being defined via `attr_accessor` and then immediately redefined with `define_method`. Fix by using `attr_writer` instead of `attr_accessor`, so that the attr reader is not defined twice.
mattbrictson
force-pushed
the
fix-method-redefined-warning
branch
from
36a0e6d to
b7f8fb8
Compare
|
@n-rodriguez rebased ✔️ |
|
@mattbrictson Thank you! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Ruby warnings are enabled, this is printed when loading the sitemap_generator gem:
This is because an attr reader (e.g.
sitemap_sample) was being defined viaattr_accessorand then immediately redefined withdefine_method.Fix by using
attr_writerinstead ofattr_accessor, so that the attr reader is not defined twice.