Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix player release #12

Merged
merged 1 commit into from
Dec 24, 2024
Merged

Fix player release #12

merged 1 commit into from
Dec 24, 2024

Conversation

SimonSchubert
Copy link
Contributor

I suspect the line got lost somewhere since your function already "removes the player element from the DOM."

Without the fix I am not able to play different songs with a single player instance under the same htmlId

kkostov
kkostov approved these changes Dec 24, 2024
View reviewed changes
Copy link
Owner

@kkostov kkostov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonSchubert Good catch! Thank you for the PR!

@kkostov kkostov merged commit 18dcebc into kkostov:main Dec 24, 2024
4 checks passed
@SimonSchubert
Copy link
Contributor Author

Thank you for the awesome library

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@kkostov kkostov kkostov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonSchubert @kkostov