Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: cairo_run for functions in namespaces #220

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ClementWalter
Copy link
Member

@ClementWalter ClementWalter commented Dec 6, 2024

Given a cairo file like

namespace Foo {

    func bar() {
        return ();
    }
}

the cairo_run should use

cairo_run("Foo.bar", ...)

@ClementWalter ClementWalter added the blocked Blocked by an external dependency label Dec 9, 2024
@ClementWalter
Copy link
Member Author

Blocked by incorrect types in some sw corelibe

starkware.cairo.lang.compiler.preprocessor.preprocessor_error.PreprocessorError:
/home/runner/work/keth/keth/.venv/lib/python3.10/site-packages/starkware/cairo/common/cairo_secp/signature.cairo:149:20: Expected expression of type 'starkware.cairo.common.cairo_secp.bigint3.SumBigInt3', got 'starkware.cairo.common.cairo_secp.bigint3.BigInt3'.
E                   return is_zero(reduced_diff);

@Eikix
Copy link
Member

Eikix commented Mar 10, 2025

Should we close this PR for now and come back later to it?
I can also convert it into a P2 issue

@enitrat enitrat marked this pull request as draft March 10, 2025 09:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
blocked Blocked by an external dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants