Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(thread_replies): Add module to handle own Twitter thread replies #35

Merged
merged 13 commits into from
Jan 31, 2021

Conversation

klausi
Copy link
Owner

@klausi klausi commented Jan 17, 2021

Fixes #34

@bajtos
Copy link
Contributor

bajtos commented Jan 26, 2021

Awesome improvement, @klausi.

It makes me wonder how is this going to interact with deleting old tweets.

In my experience, most of the time I execute mastodon-twitter-sync, it deletes only subset of tweets to avoid hitting rate limit. Could it happen that when we abort cleanup early, we end up with a partially-deleted thread that will be handled incorrectly by the next sync?

I guess this depends on the cleanup algorithm. If it deletes threads from the most-recent post to the oldest one, then all should be good. However, if we delete from the oldest tweets, then we may delete the "parent" tweet but keep "child" replies around?

@klausi
Copy link
Owner Author

klausi commented Jan 30, 2021

Yes, we could end up with partially deleted threads. Child posts would stay around until they are old enough to be deleted. I think that is a bit ugly but should not be a problem otherwise.

I think I'm almost finished here, just had some problems during testing where Twitter attachments are used. I will look into that a bit and then this can be merged I think.

@klausi klausi marked this pull request as ready for review January 31, 2021 11:59
@klausi klausi merged commit 86e0526 into master Jan 31, 2021
@klausi klausi deleted the twitter-threads branch January 31, 2021 12:00
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support synchronization of threads
2 participants