Update checkout rebuilding #107
Conversation
CHANGELOG.md
Outdated
| @@ -6,9 +6,15 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|
|||
| ### [Unreleased] | |||
|
|
|||
| ### [2.2.0] - 2021-08-18 | |||
There was a problem hiding this comment.
I think this should be 2021-05-18
|
|
||
| use Magento\Quote\Api\CartRepositoryInterface; | ||
| use Magento\Quote\Api\Data\CartExtensionFactory; | ||
| use Magento\Quote\Model\QuoteIdToMaskedQuoteId; |
There was a problem hiding this comment.
what happens to customers on version pre 2.3? If you look at https://github.com/magento/magento2/tree/2.2/app/code/Magento/Quote/Model it does not exist.
There was a problem hiding this comment.
we'll probably have to add this as a dependency
|
Hi, On Magento 2.3.3 when we apply coupon code getting the error as below. {"messages":{"error":[{"code":500,"message":"Fatal Error: 'Uncaught TypeError: Argument 2 passed to Klaviyo\Reclaim\Plugin\Api\CartSearchRepository::afterGetList() must be an instance of Magento\Quote\Model\CartSearchResults, instance of Magento\Framework\Api\SearchResults given, defined in /var/www/html/magento2/app/code/Klaviyo/Reclaim/Plugin/Api/CartSearchRepository.php:49 |
|
Thanks @webdev2k21 we will look into this |
|
@webdev2k21 it appears to be a problem where your version does not have it like the 2.3 version magento has here: https://github.com/magento/magento2/blob/2.3/app/code/Magento/Quote/Model/CartSearchResults.php I wonder if there is way to be still on 2.3 and get the latest updates for module-quote ? |
| public function getMaskedIdFromQuoteId($quoteId) | ||
| { | ||
| try { | ||
| $quoteId = $this->quoteIdMask->execute($quoteId); |
There was a problem hiding this comment.
@remstone7 @klaviyojad
FYI this change causing ~2x slow down (and sometimes fatal errors with memory limit exceeded) on the quotes list retrieval request, but that's an issue in the Magneto core.
More details here: magento/magento2#33324
No description provided.