Merge pull request #42 from klaviyo/202106_fix_identify_call

fix identify call

CHANGELOG.md

@@ -1,5 +1,8 @@
 ## CHANGELOG
 
+### 3.1.3
+- Fix identify ID call.
+
 ### 3.1.2
 - Added support for Campaigns API
 

klaviyo/__init__.py

@@ -1,2 +1,2 @@
-__version__ = '3.1.2'
+__version__ = '3.1.3'
 from .api import Klaviyo

klaviyo/public.py

@@ -118,8 +118,11 @@ def identify(self, email=None, external_id=None, properties={}, is_test=False):
         if not isinstance(properties, dict):
             properties = {}
 
-        if email: properties['email'] = email
-        if id: properties['id'] = external_id
+        if email:
+            properties['email'] = email
+
+        if external_id:
+            properties['id'] = external_id
 
         params = {
             self.TOKEN: self.public_token,

tests/fixtures/public.py

@@ -0,0 +1,17 @@
+from mock import patch
+import pytest
+from klaviyo.public import Public
+from .api_helper import KlaviyoAPIFixture
+
+class PublicFixture(KlaviyoAPIFixture):
+    @property
+    def api(self):
+        return Public(**self.API_SETTINGS)
+
+    @pytest.fixture
+    def mock_email(self):
+        return 'thomas.jefferson@mailinator.com'
+
+    @pytest.fixture
+    def mock_external_id(self):
+        return 123

tests/test_public.py

@@ -0,0 +1,19 @@
+import pytest
+from .fixtures.public import PublicFixture
+from klaviyo.exceptions import (
+    KlaviyoException
+)
+
+
+class TestPublicApi(PublicFixture):
+    def test_identify_with_id(self, mock_email, mock_external_id, mock_request):
+        self.api.identify(mock_email, mock_external_id)
+        mock_request.assert_called_once()
+
+    def test_identify_without_id(self, mock_email, mock_request):
+        self.api.identify(mock_email)
+        mock_request.assert_called_once()
+
+    def test_identify_without_identification(self):
+        with pytest.raises(KlaviyoException):
+            self.api.identify()