Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

ProcessReferencesServiceのリファクタリング #94

Closed
kmycode opened this issue Oct 11, 2023 · 0 comments · Fixed by #329
Closed

ProcessReferencesServiceのリファクタリング #94

kmycode opened this issue Oct 11, 2023 · 0 comments · Fixed by #329
Labels
bug Something isn't working cost-high refactoring test

Comments

@kmycode
Copy link
Owner

kmycode commented Oct 11, 2023

欲しい機能

ProcessReferencesService（投稿から参照を抽出して関連付ける）をリファクタリングする

必要性

いろいろな概念を入れ込みすぎて処理がこちゃこちゃになっており、自分でも判読が難しい
編集で同じURLの参照を引用に変更する処理にバグがあるが、コードが複雑で修正できない状態
また、投稿に別途引用URLが指定されていても、それが有効に動作する場合としない場合がある（テストでも判別不可能）

テストコードはすでに書いてあるので、この機会にすっきりさせたい
@kmycode kmycode added refactoring bug Something isn't working cost-high labels Oct 11, 2023
@kmycode kmycode added the test label Dec 1, 2023
@kmycode kmycode mentioned this issue Dec 4, 2023
Merged
1 task
kmycode added a commit that referenced this issue Dec 6, 2023
@kmycode
Fix: #94 ProcessReferencesServiceリファクタリング・編集時の参照引用変更バグ修正 (#329)
0ed5577 
* Fix: `ProcessReferencesService`リファクタリング・編集時の参照引用変更バグ修正

* Fix test

* Fix index_with

* Fix to method chain
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug Something isn't working cost-high refactoring test
Projects
None yet
Milestone
No milestone
1 participant
@kmycode