Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

When scheduling multiple campaigns at the exact same time, not all complete #1616

Closed
sjoerdvanderhoorn opened this issue Dec 4, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@sjoerdvanderhoorn
Copy link
Contributor

Version:

  • listmonk: 2.4.0
  • OS: Docker

Description of the bug and steps to reproduce:
When scheduling multiple campaigns to send at the exact same time, the status of all of them changes to "running" as the scheduled time occurs, but only a portion of them will fully send and change their status to "finished".

This has happened to me multiple times. The last time was earlier today, where only 8 out of 28 scheduled campaigns completed.

Pausing and resending a campaign does not resolve the issue or send the emails. Note that pausing, cancelling, or restarting a campaign is not added to the logs either.

Screenshots:

Below is an anonymous copy of the log for the campaigns that were supposed to send this morning. As you can see, 28 campaigns were started but only 8 finished.

2023/12/04 05:30:04start processing campaign (XXXXXXXX-2023-12-04-YYYY)
2023/12/04 05:30:04campaign (XXXXXXXX-2023-12-04-YYYY) finished
2023/12/04 05:30:04start processing campaign (XXXXXXXX-2023-12-04-YYYY)
2023/12/04 05:30:04campaign (XXXXXXXX-2023-12-04-YYYY) finished
2023/12/04 05:30:04start processing campaign (XXXXXXXX-2023-49-YYYY)
2023/12/04 05:30:04campaign (XXXXXXXX-2023-49-YYYY) finished
2023/12/04 05:30:04start processing campaign (XXXXXXXX-2023-12-04-YYYY)
2023/12/04 05:30:04start processing campaign (XXXXXXXX-2023-12-04-YYYY)
2023/12/04 05:30:05start processing campaign (XXXXXXXX-2023-49-YYYY)
2023/12/04 05:30:05start processing campaign (XXXXXXXX-2023-12-04-YYYY)
2023/12/04 05:30:05start processing campaign (XXXXXXXX-2023-12-04-YYYY)
2023/12/04 05:30:05start processing campaign (XXXXXXXX-2023-12-04-YYYY)
2023/12/04 05:30:05start processing campaign (XXXXXXXX-2023-12-04-YYYY)
2023/12/04 05:30:05start processing campaign (XXXXXXXX-2023-12-04-YYYY)
2023/12/04 05:30:05campaign (XXXXXXXX-2023-12-04-YYYY) finished
2023/12/04 05:30:05start processing campaign (XXXXXXXX-2023-12-04-YYYY)
2023/12/04 05:30:05start processing campaign (XXXXXXXX-2023-12-04-YYYY)
2023/12/04 05:30:05start processing campaign (XXXXXXXX-2023-12-04-YYYY)
2023/12/04 05:30:05start processing campaign (XXXXXXXX-2023-12-04-YYYY)
2023/12/04 05:30:05campaign (XXXXXXXX-2023-12-04-YYYY) finished
2023/12/04 05:30:05start processing campaign (XXXXXXXX-2023-12-04-YYYY)
2023/12/04 05:30:05start processing campaign (XXXXXXXX-2023-12-04-YYYY)
2023/12/04 05:30:05start processing campaign (XXXXXXXX-2023-12-04-YYYY)
2023/12/04 05:30:05campaign (XXXXXXXX-2023-12-04-YYYY) finished
2023/12/04 05:30:05start processing campaign (XXXXXXXX-2023-12-04-YYYY)
2023/12/04 05:30:05start processing campaign (XXXXXXXX-2023-12-04-YYYY)
2023/12/04 05:30:05start processing campaign (XXXXXXXX-2023-12-04-YYYY)
2023/12/04 05:30:05start processing campaign (XXXXXXXX-2023-12-04-YYYY)
2023/12/04 05:30:05start processing campaign (XXXXXXXX-2023-12-04-YYYY)
2023/12/04 05:30:05campaign (XXXXXXXX-2023-12-04-YYYY) finished
2023/12/04 05:30:05start processing campaign (XXXXXXXX-2023-12-04-YYYY)
2023/12/04 05:30:05start processing campaign (XXXXXXXX-2023-12-04-YYYY)
2023/12/04 05:30:05start processing campaign (XXXXXXXX-2023-12-04-YYYY)
2023/12/04 05:30:05start processing campaign (XXXXXXXX-2023-12-04-YYYY)
2023/12/04 05:30:05start processing campaign (XXXXXXXX-2023-12-04-YYYY)
2023/12/04 05:30:05campaign (XXXXXXXX-2023-12-04-YYYY) finished

@sjoerdvanderhoorn sjoerdvanderhoorn added the bug Something isn't working label Dec 4, 2023
knadh added a commit that referenced this issue Dec 22, 2023
- Sent count is no longer the batch size fetched from the DB but is
  the actual count of messages sent.
- Pausing and resuming now accurately tracks the last subscriber that
  was processed and resumes from there.
- Fix multiple concurrent campaigns blocking.

Closes #1616. Closes #905. Closes #1496. Closes #1250.
knadh added a commit that referenced this issue Dec 23, 2023
- Sent count is no longer the batch size fetched from the DB but is
  the actual count of messages sent.
- Pausing and resuming now accurately tracks the last subscriber that
  was processed and resumes from there.
- Fix multiple concurrent campaigns blocking.

Closes #1616. Closes #905. Closes #1496. Closes #1250. Closes #1010.
@knadh
Copy link
Owner

knadh commented Dec 29, 2023

This is fixed in 2efa5a5.

@knadh knadh closed this as completed Dec 29, 2023
knadh added a commit that referenced this issue Jan 4, 2024
- Sent count is no longer the batch size fetched from the DB but is
  the actual count of messages sent.
- Pausing and resuming now accurately tracks the last subscriber that
  was processed and resumes from there.
- Fix multiple concurrent campaigns blocking.

Closes #1616. Closes #905. Closes #1496. Closes #1250. Closes #1010.
@sjoerdvanderhoorn
Copy link
Contributor Author

Thanks! I can confirm this fix works like intended.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants