fix: forwardemail bounce processing invalid signature issue #2250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ai-armageddon
pushed a commit
to Twitter-outreach/ListMonk
that referenced
this pull request
Mar 11, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the forwardemail bounce processing and adds some checks (encoding / payload types) to signature validation. Relates to: #2246
Also fixes frontend build issues around yarn caching blocking developer setup / install (make dist) described here: storybookjs/storybook#22431 (comment)
Happy to move that 2nd item that changes frontend (yarn.lock / package.json) to another PR if needed. It looks like build is blocked though without it.