removing-redundant-go-fmt #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome @nitishchauhan0022! It looks like this is your first PR to knative/actions 🎉 |
knative-prow
bot
added
the
size/S
|
@dprotaso PTAL |
|
/assign @kvmware |
|
@nitishchauhan0022 Thanks for the PR. Instead of making this change here lets break it out as per #104 which you assigned yourself to. /hold don't merge, wait for it to be broke out |
knative-prow
bot
added
the
do-not-merge/hold
|
Can we merge this? It doesn't look like there's progress on #104 |
|
/lgtm |
krsna-m
removed
the
do-not-merge/hold
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, nitishchauhan0022 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing gofmt as goimports does the work of gofmt
Fixes #115