Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Modularize reusable style workflow #40

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Conversation

krsna-m
Copy link
Contributor

@krsna-m krsna-m commented Jun 16, 2022

This removes the logic from lint.yaml which is only for this repo, to reusable_style.yaml and modularizes out the logic into composite actions.

A follow up will be made to combine the old reusable style.yaml workflow with this new one.

@krsna-m krsna-m requested a review from dprotaso June 16, 2022 20:49
@knative-prow
Copy link

knative-prow bot commented Jun 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kvmware

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 16, 2022
@krsna-m
Copy link
Contributor Author

krsna-m commented Jun 16, 2022

Seems like the github action linter does not like composite actions with inputs :/ Although, they clearly work...

@krsna-m krsna-m requested a review from upodroid June 16, 2022 23:47
@upodroid
Copy link
Member

yeah, https://github.com/rhysd/actionlint has many changes since last version has been cut

@krsna-m
Copy link
Contributor Author

krsna-m commented Jun 22, 2022

rhysd/actionlint#46 looks like composite action linting is not supported yet :(

@upodroid
Copy link
Member

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2022
@knative-prow knative-prow bot merged commit d018db7 into knative:main Jun 28, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants