-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Use kmeta.ChildName() to generate OIDC service account name #7521
Conversation
Signed-off-by: pingjiang <xiangpingjiang1998@gmail.com>
Hi @xiangpingjiang. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7521 +/- ##
=======================================
Coverage 75.55% 75.55%
=======================================
Files 261 261
Lines 14667 14668 +1
=======================================
+ Hits 11082 11083 +1
Misses 3006 3006
Partials 579 579 ☔ View full report in Codecov by Sentry. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this @xiangpingjiang
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, xiangpingjiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #7470
Proposed Changes
Pre-review Checklist
Release Note
Docs