Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add a Prerequisite helper to check if the OIDC authentication feature flag is enabled #7609

Merged

Conversation

creydr
Copy link
Member

@creydr creydr commented Jan 22, 2024

Allows to add a Prerequiste check in an e2e test, so the test runs only in case the authorization-oidc feature flag is enabled.

Usage:

f.Prerequisite("OIDC authentication is enabled", featureflags.AuthenticationOIDCEnabled())

@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/test-and-release Test infrastructure, tests or release labels Jan 22, 2024
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2024
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7cba45b) 74.52% compared to head (578a6e7) 74.54%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7609      +/-   ##
==========================================
+ Coverage   74.52%   74.54%   +0.02%     
==========================================
  Files         262      262              
  Lines       14970    14970              
==========================================
+ Hits        11157    11160       +3     
+ Misses       3223     3221       -2     
+ Partials      590      589       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2024
Copy link

knative-prow bot commented Jan 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@creydr
Copy link
Member Author

creydr commented Jan 22, 2024

/retest

2 similar comments
@creydr
Copy link
Member Author

creydr commented Jan 22, 2024

/retest

@creydr
Copy link
Member Author

creydr commented Jan 23, 2024

/retest

@knative-prow knative-prow bot merged commit 6962251 into knative:main Jan 23, 2024
38 of 41 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants