Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add Travis CI with Flaks8 validation - issue #5 #9

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add Travis CI with Flaks8 validation - issue #5 #9

wants to merge 5 commits into from

Commits on Nov 29, 2019

  1. adding app.py to solved the challenge 

    Cheange after review from Aviad, used with.. open, variable names cheanged, pass flake8 lint rules

broke the last print into 2 prints commands

added yml for testing flake8 on travis CI

comiited the wrong file before

Delete app.py

only want on this PR .travis.yml
    @BarakMerdler
    BarakMerdler committed Nov 29, 2019
    Configuration menu
    Copy the full SHA
    3edf4ca View commit details
    Browse the repository at this point in the history

  2. commiting python file that is not going to pass flake8 rules to check… 

    … the script
    @BarakMerdler
    BarakMerdler committed Nov 29, 2019
    Configuration menu
    Copy the full SHA
    2e060ae View commit details
    Browse the repository at this point in the history

  3. commiting python file that is going to pass flake8 rules to check the… 

    … script
    @BarakMerdler
    BarakMerdler committed Nov 29, 2019
    Configuration menu
    Copy the full SHA
    1e5cc32 View commit details
    Browse the repository at this point in the history

  4. delete app.js 

    delete from this PR
added just to check if .yml is working as expected
    @BarakMerdler
    BarakMerdler authored Nov 29, 2019
    Configuration menu
    Copy the full SHA
    687918f View commit details
    Browse the repository at this point in the history

  5. Add Travis CI with Flaks8 validation issue knowabli#5

    @BarakMerdler
    BarakMerdler authored Nov 29, 2019
    Configuration menu
    Copy the full SHA
    b7139cb View commit details
    Browse the repository at this point in the history