Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

closes knowm/XChange#3647 Added support for tinyproxy acting as reverse proxy. #4263

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

scrisini
Copy link

@scrisini scrisini commented Sep 8, 2021

This will support a reverse proxy setup such as tinyproxy
when connecting to any of the supported exchanges
used
by a spring java app like this
image
use case
is going thr a lightweight firewall like tinyproxy

@scrisini scrisini changed the title Added support for tinyproxy acting as reverse proxy. Support known/XChange#3647 Added support for tinyproxy acting as reverse proxy. Sep 8, 2021
@scrisini scrisini changed the title Support known/XChange#3647 Added support for tinyproxy acting as reverse proxy. closes known/XChange#3647 Added support for tinyproxy acting as reverse proxy. Sep 8, 2021
@scrisini scrisini changed the title closes known/XChange#3647 Added support for tinyproxy acting as reverse proxy. closes knowm/XChange#3647 Added support for tinyproxy acting as reverse proxy. Sep 8, 2021
@timmolter
Copy link
Member

dumb question: couldn't you just run nginx or something to do that?

@timmolter
Copy link
Member

Or is it that the code in XChange for streaming somehow needs to be modified? Why exactly?

@scrisini
Copy link
Author

scrisini commented Nov 3, 2021

HI Tim
yes specifically for streaming and the additional functionality is to bridge the gap in setting up web socket session when a proxy is used in between
Changes are

  1. invoke applyStreamingSpefication on connect in class XXXStreamingExchange
  2. set the proxy host and port in method applyStreamingSpec - StreamingExchange
  3. Add a proxy friendly handler in nettStreamingService if proxys are given.
  4. and importantly WebSocketClientHandler to manage the handshake when a proxy is used
    I hope this is considered for inclusion as there shouldn't be an impact on the main flow but will be useful for proxy based implementation
    and tinyproxy is used as a lightweight firewall to block or white listed web socket url.
    particularly important in our industry.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants